Remove 4GB file size workaround for 32bit OS / Stream Videos on IOS

[schoetju]

Like described in #108 there are still issues, when

• Nextcloud is running on 32 Bit-OS (like mine running on RPI)
• iOS-Clients want to access Movies

The workaround initially introduced with #74 is not necessary anymore. By the time the 64-Bit-Coding has been improved to serve 4MB chunks that don't hurt on 32Bit-systems.

There are similar recommendations (like https://help.nextcloud.com/t/ios-nextcloud-client-does-not-play-videos/99790/4 ) to step into the 64Bit-Coding always by changing >4 to >0

This Pull-Request simply deletes the separation of 64/32 Bitsystems

[codecov]

Codecov Report

Merging #184 (110e1d0) into master (d7f0d93) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     94.02%   94.11%   +0.09%     
+ Complexity      262      260       -2     
============================================
  Files            15       15              
  Lines           887      884       -3     
============================================
- Hits            834      832       -2     
+ Misses           53       52       -1     

Impacted Files	Coverage Δ
lib/Sapi.php	97.19% <100.00%> (+0.83%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[phil-davis]

This looks to be a reasonable thing to me. The 4MB "chunking loop" done in the 64-bit case is also a solution for the previous 32-bit problem.

[schoetju]

I've reduced the indent (updated the patch-1 version). code-style checks should be ok now.

[staabm]

Lgtm. Is this code covered by tests?

[schoetju]

It's running fine on my instance (and solved the iOS-Movie issue).

[phil-davis]

codecov is being troublesome because actually the relevant unit tests in tests/HTTP/SapiTest.php are being skipped because they get skipped if xdebug functions are missing. And since changing to GitHub workflows, the CI has been using pcov for coverage, and that stops xdebug from being available.

I am getting that sorted out in PR #185 - then we will get all the unit tests run, and should get better coverage reports.

[phil-davis]

I rebased to get tests running in CI as per #185 - all tests now run and pass, and coverage does not complain.
The code here is covered for cases of small size streamed bodies. There are not specific tests for big files, but for the 64-bit case the code is the same as previous. For 32-bit, we don't have test pipelines that run in a 32-bit environment anyway.

@schoetju thanks - merging

[MichaIng]

It seems the workaround is still required to work with 32-bit systems in Nextcloud: nextcloud/server#34674

I didn't exactly track the issue down to this part of the code, but down to sabre, and the issue appeared with the release which contained this commit the first time.

Since all clients' file sync (+ files app in web UI) are broken on 32-bit systems, I guess video streaming from iOS (which was the reason for removing this workaround) isn't working anymore either.

Not sure where to fix this best, whether to revert this commit, apply a fix for #108 on Nextcloud end, or the other way around, e.g. checking why this 4 MiB chunking theory does not apply, but wanted to bring this to your attention.

[MichaIng]

I was wrong: The same sabre/http version has been merged into earlier Nextcloud 24 version as well, not causing issues there. It matched so perfectly 😅.