-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow testSendToGetLargeContent peak memory usage to be specified externally #187
Allow testSendToGetLargeContent peak memory usage to be specified externally #187
Conversation
d323dd0
to
eb2de30
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=========================================
Coverage 94.11% 94.11%
Complexity 260 260
=========================================
Files 15 15
Lines 884 884
=========================================
Hits 832 832
Misses 52 52 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
eb2de30
to
ca27e59
Compare
And I think that I will have to make a patch release so that |
e4e1a56
to
94321c1
Compare
See discussion sabre-io/dav#1409 (comment)
The 'sabre/http' PHP unit tests are also run in the
sabre/dav
CI. The PHP environment is a bit "bigger" there, andmemory_get_peak_usage()
returns about 70MB, above the 60MB limit that the test allows.This PR adds an env variable that can be defined to specify the peak memory usage that is allowed for the test. That will let us be more flexible in other CI.
I called it
SABRE_HTTP_TEST_GET_LARGE_CONTENT_MAX_PEAK_MEMORY_USAGE
- naming is hard, and I wanted a name that won't conflict with anything else in anyone's environment!