Fix various small typos and grammar #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=========================================
Coverage 94.11% 94.11%
Complexity 260 260
=========================================
Files 15 15
Lines 884 884
=========================================
Hits 832 832
Misses 52 52
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
phil-davis
commented
Jul 15, 2022
| @@ -133,7 +133,7 @@ protected function validate(): bool | |||
| return false; | |||
| } | |||
| // We need to add an md5 of the entire request body to the A2 part of the hash | |||
| $body = $this->request->getBody($asString = true); | |||
| $body = $this->request->getBody(); | |||
There was a problem hiding this comment.
getBody() is declared with no parameters, so passing a parameter here is meaningless - or do I miss something?
staabm
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I let the IDE tell me about this stuff.