Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .gitattributes #191

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Create .gitattributes #191

merged 1 commit into from
Jul 27, 2022

Conversation

cedric-anne
Copy link
Contributor

Add .gitattributes to exclude files/directories from dist package.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #191 (e91aba4) into master (9976ac3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage     94.11%   94.11%           
  Complexity      260      260           
=========================================
  Files            15       15           
  Lines           884      884           
=========================================
  Hits            832      832           
  Misses           52       52           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@phil-davis phil-davis merged commit 3000a8a into sabre-io:master Jul 27, 2022
@cedric-anne cedric-anne deleted the patch-1 branch July 27, 2022 15:14
@phil-davis
Copy link
Contributor

Note: this means that the test code is not in the release distribution package, which is nicer for production installs (they don't want or need all that extra crud)

Some upstream CI tries to run the sabre/http unit tests. For example sabre/dav sabre-io/dav#1439 can't find the sabre/http unit tests.

That is all fine, and I will sort out what to do in sabre/dav. I am just making this comment here so that it might help future people who are searching for where this changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants