-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CURLOPT_HTTPHEADER Setting Assignment #215
Merged
phil-davis
merged 2 commits into
sabre-io:master
from
amrita-shrestha:remove-header-overwrite-with-null
Aug 17, 2023
Merged
Improve CURLOPT_HTTPHEADER Setting Assignment #215
phil-davis
merged 2 commits into
sabre-io:master
from
amrita-shrestha:remove-header-overwrite-with-null
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage 94.21% 94.21%
- Complexity 260 261 +1
=========================================
Files 15 15
Lines 881 882 +1
=========================================
+ Hits 830 831 +1
Misses 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@amrita-shrestha php-cs-fixer wants a code-format change: You can locally do: |
phil-davis
reviewed
Aug 17, 2023
staabm
reviewed
Aug 17, 2023
amrita-shrestha
force-pushed
the
remove-header-overwrite-with-null
branch
2 times, most recently
from
August 17, 2023 09:13
a622479
to
3caa370
Compare
phil-davis
reviewed
Aug 17, 2023
amrita-shrestha
force-pushed
the
remove-header-overwrite-with-null
branch
from
August 17, 2023 10:02
3caa370
to
39bb6b0
Compare
phil-davis
approved these changes
Aug 17, 2023
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR code prevents potential issues that could arise from setting CURLOPT_HTTPHEADER with an empty value. By adding a conditional check, we ensure that we only assign meaningful and valid header values.
Testing: