Test enhancement #98
Closed
Test enhancement #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
============================================
+ Coverage 89% 89.76% +0.76%
Complexity 244 244
============================================
Files 15 15
Lines 782 782
============================================
+ Hits 696 702 +6
+ Misses 86 80 -6
Continue to review full report at Codecov.
|
jens1o
reviewed
Mar 16, 2018
staabm
reviewed
Mar 16, 2018
| @@ -340,7 +340,6 @@ function parseMimeType(string $str) : array { | |||
| $mimeType = explode('/', $mimeType); | |||
| if (count($mimeType) !== 2) { | |||
| // Illegal value | |||
| var_dump($mimeType);die(); | |||
Merged
|
A rebased version is in PR #176 |
|
The test changes have been merged in #176 - thanks I will make a separate commit and PR to fixup the code change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log