358 Bugfix Broker::processMessageReply #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
strokyl
force-pushed
the
358_bugfix_exception_process_message_reply
branch
from
b523a00
to
bb65fce
Compare
staabm
reviewed
May 2, 2024
There was a problem hiding this comment.
I can't say someting useful on this area of the codebase.
since the change is covered by a test, I would be fine with merging it into the master branch though. I would not immediately backport it, until it was used in the wild on the latest version for now.
wdyt @phil-davis ?
|
@strokyl could you rebase? |
Lol, this PR is 8 year old. I am not working on sabre anymore at all. I don't remember the how/why of this PR at all and don't have the sabre base code on my laptop now! |
|
@gharlan could you create a rebased version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit processMessageReply did not work for exceptions with
a reccurent id in an other timezone than the dtstart of the master event.