Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding detection on PHP 8.1 #575

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 14, 2022

Also get rid of deprecated utf8_encode

Spin-off of sabre-io/http#182

Also get rid of deprecated utf8_encode
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #575 (3f4b735) into master (a595790) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #575      +/-   ##
============================================
- Coverage     98.34%   98.34%   -0.01%     
  Complexity     1885     1885              
============================================
  Files            71       71              
  Lines          4529     4526       -3     
============================================
- Hits           4454     4451       -3     
  Misses           75       75              
Impacted Files Coverage Δ
lib/StringUtil.php 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@phil-davis phil-davis merged commit db542a5 into sabre-io:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants