Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove utf8_encode #599

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 9, 2022

Apply "Remove utf8_encode" to 4.5 so that we can make a simple 4.5.1 release, without all the arg/return-type changes that are in progress on master.

And add PHP 8.2 to the CI here, to demonstrate that it passes.

@phil-davis phil-davis self-assigned this Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #599 (167a599) into 4.5 (d1fdc0c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                4.5     #599      +/-   ##
============================================
- Coverage     98.35%   98.35%   -0.01%     
  Complexity     1897     1897              
============================================
  Files            71       71              
  Lines          4550     4548       -2     
============================================
- Hits           4475     4473       -2     
  Misses           75       75              
Impacted Files Coverage Δ
lib/Parser/MimeDir.php 99.56% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis marked this pull request as ready for review October 9, 2022 10:06
@phil-davis phil-davis merged commit 1f83674 into sabre-io:4.5 Oct 9, 2022
@phil-davis phil-davis deleted the remove-utf8_encode-for-4.5 branch October 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant