-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence operator on read #88
Comments
If it's fixed in the minimum supported PHP version then I agree that it can be removed. Currently the minimum version is 5.4.1. I would be willing to increase the revision number as the minimum version, if the bug is fixed somewhere in 5.4.x. Any idea if it was? |
i have no idea, and can not deduce it from the bug report either. |
Here's the github commit: Tags: 5.4.22, 5.5.5, 5.6.0. A two-year old release.. I think I can be ok with increasing the minimum versions to those in the next minor version (1.5.0). |
Unfortunately we recently found out that this was still needed to support hhvm, which emits errors regardless of this setting. So I'm reverting this until it's also fixed in hhvm. |
Is the silence operator still needed?
(also the one mentioned in #87 )
https://github.com/fruux/sabre-xml/blob/master/lib/Reader.php#L65
https://github.com/fruux/sabre-xml/blob/master/lib/Reader.php#L145
It seems the issue/bug has been fixed
https://bugs.php.net/bug.php?id=64230
Testing your example code from that bug report
does not throw errors here (php 5.6.14)
The text was updated successfully, but these errors were encountered: