Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in subed.el (subed-prepare-for-save) #56

Closed
muello opened this issue Jan 23, 2022 · 4 comments
Closed

typo in subed.el (subed-prepare-for-save) #56

muello opened this issue Jan 23, 2022 · 4 comments

Comments

@muello
Copy link

muello commented Jan 23, 2022

(add-hook 'before-save-hook #'subed-prepare-for-save :append :local)

should apparently be prepare to save

@sachac
Copy link
Owner

sachac commented Jan 23, 2022 via email

@sachac
Copy link
Owner

sachac commented Jan 23, 2022

@muello: Hmm, it looks like the latest at https://github.com/sachac/subed/blob/derived-mode/subed/subed.el#L129 does have subed-prepare-to-save. Could you please try updating your version with git pull origin derived-mode in case you have an older commit? You can check with git log. The latest is 5e9518d . Hope that helps!

@sachac
Copy link
Owner

sachac commented Jan 23, 2022

.... oh, it's because I had also made that change on main and I forgot to propagate the fix. I hadn't noticed because the tests don't save anything and I've been using the derived-mode branch to edit the files I was saving. Ugh, I'm sorry about that! It should be fixed now if you update it from the main branch. Assuming the Github remote is called origin:

git fetch origin
git checkout origin/main -b main

@muello
Copy link
Author

muello commented Jan 23, 2022

ah yes, i was on main. it looks good on both to me now!

@muello muello closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants