-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in subed.el (subed-prepare-for-save) #56
Comments
Whoops, I thought I pushed my fix to that branch. I'll fix it tonight.
Thanks for trying it out!
…On Sun., Jan. 23, 2022, 14:29 muello, ***@***.***> wrote:
(add-hook 'before-save-hook #'subed-prepare-for-save :append :local)
should apparently be prepare *to* save
—
Reply to this email directly, view it on GitHub
<#56>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACD7EVBJW4J7WTTISYVVLLUXRJKHANCNFSM5MTW7JOA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@muello: Hmm, it looks like the latest at https://github.com/sachac/subed/blob/derived-mode/subed/subed.el#L129 does have subed-prepare-to-save. Could you please try updating your version with git pull origin derived-mode in case you have an older commit? You can check with git log. The latest is 5e9518d . Hope that helps! |
.... oh, it's because I had also made that change on main and I forgot to propagate the fix. I hadn't noticed because the tests don't save anything and I've been using the derived-mode branch to edit the files I was saving. Ugh, I'm sorry about that! It should be fixed now if you update it from the main branch. Assuming the Github remote is called origin:
|
ah yes, i was on main. it looks good on both to me now! |
(add-hook 'before-save-hook #'subed-prepare-for-save :append :local)
should apparently be prepare to save
The text was updated successfully, but these errors were encountered: