Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59 : add chord.bass and chord.inverted() #61

Closed
wants to merge 2 commits into from

Conversation

gsouf
Copy link

@gsouf gsouf commented Dec 31, 2014

Fix #59
I added a few testes, but i didnt run the tests. I didnt know how to run them (i'm not a javascript hacker!)

@gsouf gsouf changed the title Fix #59 : add chord.bass and chord.inverted Fix #59 : add chord.bass and chord.inverted() Dec 31, 2014
@saebekassebil
Copy link
Owner

Thank you very much for doing this @SneakyBobito!

I think that the chord.bass property needs to be converted into a method chord.base() because the voicing of a chord can be altered! E.g:

var am = teoria.chord('Am');
am.base().name() == 'a';
am.voicing(['P5', 'P1', 'm3']);
am.base().name() == 'e';

I like the .inverted()! Could you add some tests?

You can run the test be running npm test in the project root.

@gsouf
Copy link
Author

gsouf commented Jan 9, 2015

I will, adapt the PR asap. Stay tunned

@gsouf
Copy link
Author

gsouf commented Jan 19, 2015

Is there a way to check if two teoria.note are the same note no matter about the pitch ?

@saebekassebil
Copy link
Owner

What do you mean "no matter the pitch?".

@gsouf
Copy link
Author

gsouf commented Jan 19, 2015

I'm looking if two notes are the sames.

For instance a A low and a A high are both a A.

@saebekassebil
Copy link
Owner

note.toString(true) gives you the note name without the octave number

@saebekassebil
Copy link
Owner

Hi @gsouf - I went ahead and implemented the Chord#bass() function, which basically just returns the note voiced the lowest. Hope you'll find it useful!

@gsouf
Copy link
Author

gsouf commented May 12, 2015

Hey @saebekassebil
Sorry, my project with teoria has not been updated for weeks, I forgot this issue !

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a chord with root different from the tone
2 participants