simple array buffer #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrahams
force-pushed
the
simple-array-buffer
branch
from
522ca30
to
97a8df6
Compare
marcrasi
approved these changes
Jun 12, 2020
dabrahams
force-pushed
the
simple-array-buffer
branch
from
ce8223d
to
dc5fba0
Compare
marcrasi
reviewed
Jun 12, 2020
added 3 commits
June 13, 2020 03:43
These mutation functions allow the buffer's elements to be mutated in place without incurring spurious CoW.
dabrahams
force-pushed
the
simple-array-buffer
branch
from
2d7c58e
to
6fc353a
Compare
added 9 commits
June 16, 2020 20:59
marcrasi
reviewed
Jun 18, 2020
| public init<SrcStorage>(_ src: AnyArrayBuffer<SrcStorage>) { | ||
| self.storage = unsafeDowncast(src.storage, to: Storage.self) | ||
| /// - Requires: `p` is the address of an initialized `ArrayStorage<Element>`. | ||
| public static func asStorage(_ p: UnsafeRawPointer) -> ArrayStorage<Element> { |
There was a problem hiding this comment.
Why is p an UnsafeRawPointer instead of an AnyObject?
There was a problem hiding this comment.
Mostly fear of ARC
There was a problem hiding this comment.
IMO we should try the AnyObject arrangement and see if it slows anything down. If not, maybe that's better.
marcrasi
reviewed
Jun 18, 2020
marcrasi
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Looks good to me! I migrated SwiftFusion to this and it works. A few "feature requests" are in Sources/SwiftFusion/Inference/PenguinExtensions.swift in the migration PR but we can do them in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.