Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render missions #33

Merged
merged 7 commits into from
Oct 6, 2021
Merged

Render missions #33

merged 7 commits into from
Oct 6, 2021

Conversation

enkog
Copy link
Collaborator

@enkog enkog commented Oct 6, 2021

In this milestone, I have;

  • Used useSelector(), Redux Hook, to select the state slices and render lists of missions in corresponding routes. i.e.:

  • Render a table with the missions' data (as per design) using React Bootstrap.

@enkog enkog requested a review from safafa October 6, 2021 01:46
@enkog enkog linked an issue Oct 6, 2021 that may be closed by this pull request
[4pt] Display missions - Lists render #15
Closed
safafa
safafa requested changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@safafa safafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUESTED ♻️

Hi @enkog , You did a great job so far 👏🏼 👏🏼

Required changes :

  • Check the inline comments.

safafa
safafa approved these changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@safafa safafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hello, @enkog great job working on the projects 👍 💯

Now you can merge this branch 💪 😄

@enkog enkog merged commit 45b7218 into dev Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safafa safafa safafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4pt] Display missions - Lists render
2 participants
@enkog @safafa