Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join mission #35

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Join mission #35

merged 5 commits into from
Oct 6, 2021

Conversation

enkog
Copy link
Collaborator

@enkog enkog commented Oct 6, 2021

In this milestone, I have implemented the following;

  • When a user clicks the "Join Mission" button, action is dispatched to update the store.
  • A new state is returned but the selected mission will have an extra key reserved with its value set to true.
  • Placed all logic in the reducer.
  • In the React view file, an action is dispatched with the correct mission ID as an argument.

@enkog enkog requested a review from safafa October 6, 2021 11:25
@enkog enkog linked an issue Oct 6, 2021 that may be closed by this pull request
[3pt] Implement mission joining - Actions #10
Closed
safafa
safafa approved these changes Oct 6, 2021
View reviewed changes
Copy link
Owner

@safafa safafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hello @enkog great job working on the milestone 👍 💯

Now you can merge this branch 💪 😄

@enkog enkog merged commit bd4e471 into dev Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safafa safafa safafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3pt] Implement mission joining - Actions
2 participants
@enkog @safafa