Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EIP-1193] Test relay-kit #780

Closed
yagopv opened this issue Apr 23, 2024 · 0 comments · Fixed by #770
Closed

[EIP-1193] Test relay-kit #780

yagopv opened this issue Apr 23, 2024 · 0 comments · Fixed by #770
Assignees
@yagopv

Comments

@yagopv
Copy link
Member

yagopv commented Apr 23, 2024 •
edited
Loading

Context / issue

As part of the EIP-1193 implementation, we need to retest all the related kits. This involves analyzing, executing, and updating the unit tests, integration tests, related example apps, and playgrounds.

Proposed solution

In the relay-kit

  • Check the unit tests for the 4337 pack
  • Check the unit tests for the Gelato pack
  • Check that the playgrounds continue to work

Additional context

#651
@yagopv yagopv linked a pull request May 2, 2024 that will close this issue
feat(protocol-kit): Add EIP-1193 provider support #770
Merged
@dasanra dasanra closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagopv yagopv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol-kit): Add EIP-1193 provider support safe-global/safe-core-sdk
2 participants
@yagopv @dasanra