Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delegate API client shouldn't sign the message #750

Closed
moisses89 opened this issue Jan 24, 2024 · 1 comment · Fixed by #981
Closed

Remove delegate API client shouldn't sign the message #750

moisses89 opened this issue Jan 24, 2024 · 1 comment · Fixed by #981
Assignees
@falvaradorodriguez
Labels
breaking_change Breaking change enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

The function remove_delegate of transaction service api is signing the message with wallet provided by parameter, but this signature should happens outside of the remove_delegate function to let other types of wallets as hardware wallets sign the message.
I'd suggest that remove_delegate should just receive the message_hash and the signature.
@moisses89 moisses89 added enhancement New feature or request breaking_change Breaking change labels Jan 24, 2024
@Uxio0
Copy link
Member

Uxio0 commented Jan 24, 2024

Makes total sense @moisses89 , good call

@falvaradorodriguez falvaradorodriguez mentioned this issue May 16, 2024
Merged
@falvaradorodriguez falvaradorodriguez mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falvaradorodriguez falvaradorodriguez

Labels
breaking_change Breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add method to remove delegate with provided signature safe-global/safe-eth-py
3 participants
@falvaradorodriguez @Uxio0 @moisses89