-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to remove delegate with provided signature #981
Conversation
@moisses89 when this is ready could you review it? |
Pull Request Test Coverage Report for Build 9365290507Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -305,6 +305,37 @@ def remove_delegate( | |||
raise SafeAPIException(f"Cannot remove delegate: {response.content}") | |||
return True | |||
|
|||
def remove_delegate_signed( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like to have two functions to remove delegates. We have here two options in my opinion.
- Remove the function that is signing inside
- or remove_delegate with optional signature and optional signature parameters as the signer.
I prefer the first one, because in my opinion calculate the signature is out of the goal of a client API function.
For both options we should set the label breaking_change for the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense. Removed here a7eb692
@moisses89 Seeing this it made sense to me to apply the same criteria for the add_delegate method. I have also put an optional safe parameter as in the case of delete. If you see that this doesn't apply here, please let me know and I'll revert it. Thanks |
Closes #750