Add method to remove delegate with provided signature

[falvaradorodriguez]

Closes #750

[Uxio0]

@moisses89 when this is ready could you review it?

[coveralls]

Pull Request Test Coverage Report for Build 9365290507

Details

• 32 of 32 (100.0%) changed or added relevant lines in 2 files are covered.
• 29 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.1%) to 93.482%

---

Files with Coverage Reduction	New Missed Lines	%
gnosis/eth/clients/sourcify_client.py	13	70.59%
gnosis/eth/tests/clients/test_sourcify_client.py	16	64.44%

Totals
Change from base Build 9363150402:	-0.1%
Covered Lines:	8175
Relevant Lines:	8745

---

💛 - Coveralls

[moisses89]

Looks good to me!

I was missing one thing

[moisses89]

I don't like to have two functions to remove delegates. We have here two options in my opinion.

• Remove the function that is signing inside
• or remove_delegate with optional signature and optional signature parameters as the signer.

I prefer the first one, because in my opinion calculate the signature is out of the goal of a client API function.
For both options we should set the label breaking_change for the issue.

[falvaradorodriguez]

Ok, makes sense. Removed here a7eb692

[falvaradorodriguez]

@moisses89 Seeing this it made sense to me to apply the same criteria for the add_delegate method. I have also put an optional safe parameter as in the case of delete. If you see that this doesn't apply here, please let me know and I'll revert it. Thanks