Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock py-evm==0.5.0a3 #293

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Lock py-evm==0.5.0a3 #293

merged 2 commits into from
Jul 7, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 7, 2022

  • Fix issues with dependency resolving

@Uxio0
Lock py-evm==0.5.0a3
4719b9e 
- Fix issues with dependency resolving
@coveralls
Copy link

coveralls commented Jul 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2630073771

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.004%
Totals Coverage Status
Change from base Build 2621788923: 0.2%
Covered Lines: 2954
Relevant Lines: 3246
💛 - Coveralls

fmrsabino
fmrsabino approved these changes Jul 7, 2022
View reviewed changes
setup.py
@@ -11,8 +11,7 @@
requirements = [
"cached-property>=1.5; python_version < '3.8'",
"eip712_structs",
"packaging",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was not required?

Copy link
Member Author

@Uxio0 Uxio0 Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be included in any python distribution, but we are using it, I will put it back

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

gnosis/eth/constants.py
Comment on lines +1 to +3
SECPK1_N = (
115792089237316195423570985008687907852837564279074904382605163141518161494337
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py-evm.usages-- 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't get this 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decrementing the usages of py-evm 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hahahahaha yeah!

@Uxio0 Uxio0 merged commit 3f01e6f into master Jul 7, 2022
@Uxio0 Uxio0 deleted the fix-dependency-issues branch July 7, 2022 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @fmrsabino