-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gelato using execTransaction
for gas metering
#326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
requested review from
nlordell,
akshay-ap and
mmv08
and removed request for
a team
March 14, 2024 15:57
Pull Request Test Coverage Report for Build 8328578423Details
💛 - Coveralls |
akshay-ap
requested changes
Mar 15, 2024
akshay-ap
approved these changes
Mar 15, 2024
nlordell
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There are some linter warnings that would be nice to clean up, but that can be done in a follow up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the gas metering check from using 4337
EntryPoint v0.6
to usingexecTransaction
directly in Safe.Package Lock has been updated due to the addition of the Gelato relay kit package.
Changes:
base-sepolia
as well.execTransaction
.userOp
of 4337 toexecTransaction
of Safe for Gelato-based transactions.userOps
).safe.ts
(Creating calldata, init code, etc.).userOp
related functions of Gelato.Closes #296