Add new caching logic to all-transactions #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to use a |
moisses89
force-pushed
the
fix_all_transactions_cache
branch
from
b6de858
to
05f971d
Compare
moisses89
force-pushed
the
fix_all_transactions_cache
branch
from
cf78136
to
5445a49
Compare
moisses89
force-pushed
the
fix_all_transactions_cache
branch
from
5445a49
to
0b8f25b
Compare
Uxio0
requested changes
Apr 25, 2024
safe_transaction_service/history/services/transaction_service.py
Outdated
Show resolved
Hide resolved
safe_transaction_service/history/services/transaction_service.py
Outdated
Show resolved
Hide resolved
| return (None, None) | ||
|
|
||
|
|
||
| def _clean_all_txs_cache(instance): |
There was a problem hiding this comment.
Add docs. Also maybe another python file is better to add these helper methods, as we are merging a lot of things in the signals file. Maybe refactoring all this logic into a class (if possible) could make sense
There was a problem hiding this comment.
I agree, I think that we could create a class for all the caching related with endpoints and mange the invalidation there.
We could reuse this caching methods to endpoints like multisig transactions, module transactions.
Issue created here #2008
moisses89
force-pushed
the
fix_all_transactions_cache
branch
from
5dc998b
to
3798fdd
Compare
Add cache functions documentation
moisses89
force-pushed
the
fix_all_transactions_cache
branch
from
3798fdd
to
d2af06b
Compare
Uxio0
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cache_dirwith "all-txs:safe-address"unlinkfrom signal providing thecache_dirto remove all thecache_fieldsbehind thecache_dir.Closes #1931