You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a transaction is fully signed or only the current owner's signature is missing we do not need and should not overwrite the safe's threshold and pass the manual selected or estimated gas limit.
Reason: The number of signatures matters for the transactions gas limit. If the tx will only check 1 signature instead of n>1 signatures it can occur that a successfully simulated tx reverts when being executed.
Steps to reproduce
Create a new ERC20 transfer
Go to review step
change the gas limit to 21000 (minimum)
click simulate
Observe simulation success
try to execute with that gas limit
Observe error: Your transaction was unsuccessful. [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"intrinsic gas too low"}}'
Expected result
The simulation should fail with "out of gas"
Obtained result
The simulation always uses 30 million gas as limit and always succeeds.
The text was updated successfully, but these errors were encountered:
- add prevalidated signatures if more signatures are needed and the owner's sig is missing
- pass gasLimit to txSimulation if estimated / manually set
- only overwrite threshold if necessary (threshold won't be reached otherwise)
closes issue #559 & issue #560
Bug description
If a transaction is fully signed or only the current owner's signature is missing we do not need and should not overwrite the safe's threshold and pass the manual selected or estimated gas limit.
Reason: The number of signatures matters for the transactions gas limit. If the tx will only check 1 signature instead of
n>1
signatures it can occur that a successfully simulated tx reverts when being executed.Steps to reproduce
Your transaction was unsuccessful. [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"intrinsic gas too low"}}'
Expected result
The simulation should fail with "out of gas"
Obtained result
The simulation always uses 30 million gas as limit and always succeeds.
The text was updated successfully, but these errors were encountered: