fix: "Recipient" -> "Recipient address or ENS" #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
approved these changes
Jan 20, 2023
|
I think it would be good but it takes the label as a prop and it can be any text. Although it will probably work in most cases since it's usually a noun like "Owner", "Recipient" etc. |
iamacook
approved these changes
Jan 20, 2023
|
Verified |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR makes it clearer that you can enter either an address or an ENS name in the recipient field.
Screenshots
How to test
All the places where we have address inputs – the recipient field in tx modals, address book entry modal, owner management etc – will have "or ENS" added in the label.