refactor: upgrade + optimise Redux #1981
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
| @@ -90,7 +88,10 @@ export const _hydrationReducer: typeof rootReducer = (state, action) => { | |||
| const makeStore = (initialState?: Record<string, any>) => { | |||
| return configureStore({ | |||
| reducer: _hydrationReducer, | |||
| middleware: (getDefaultMiddleware) => getDefaultMiddleware({ serializableCheck: false }).concat(middleware), | |||
| middleware: (getDefaultMiddleware) => { | |||
| listeners.forEach((listener) => listener(listenerMiddlewareInstance)) | |||
There was a problem hiding this comment.
Is there a difference in registering the listeners in this function or on the top level? In the examples from the documentation they are registered on the top level right after the middleware is created.
There was a problem hiding this comment.
I don't think so.
I moved it here as this is just before store creation/allowed for better testing. What are your thoughts?
|
LGTM Checked that sidebar updates with the safes, new safes created, added safes, owned safes in new networks |
|
@iamacook please don't merge just yet, let's create an RC w/o it first. |
What it solves
Upgrades Redux to the latest version and optimises/improves type safety of middlewares.
How this PR fixes it
react-reduxand@reduxjs/toolkithave been upgraded to the latest versions.createListenerMiddlewareHow to test it
No visible changes should be noticed:
Checklist