Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX flow] Design adjustments #2162

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[TX flow] Design adjustments #2162

merged 1 commit into from
Jun 23, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Adjusts the layout for reviewing send token txs according to the design
  • Moves Redefine block up to tx checks
  • Adds the contract interaction link in new tx menu
  • Fixes the NFT Transfer link in new tx menu

How to test it

  1. Try sending nfts and contract interaction via the new tx menu
  2. Observe the send tokens review screen

Screenshots

Screenshot 2023-06-23 at 16 04 10 Screenshot 2023-06-23 at 16 04 23

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan changed the base branch from dev to epic-tx-flow June 23, 2023 14:04
@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Branch preview

✅ Deploy successful!

https://design_adjustments--walletweb.review-wallet-web.5afe.dev

@usame-algan usame-algan changed the title Design adjustments [TX flow] Design adjustments Jun 23, 2023
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit d259685 into epic-tx-flow Jun 23, 2023
@usame-algan usame-algan deleted the design-adjustments branch June 23, 2023 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants