New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TX flow] Adjust Send NFT layout for new tx flow #2192

Merged

usame-algan merged 1 commit into epic-tx-flow from send-nft-ui

Jun 28, 2023

Member

usame-algan commented Jun 28, 2023 •

edited

Loading

What it solves

Part of #2067

How this PR fixes it

Adjusts the Send NFT flow UI according to the designs
Removes old NFT flow components

How to test it

Open a Safe
Create an NFT transfer
Compare to the designs

Screenshots

Screenshot 2023-06-28 at 16 41 38

Screenshot 2023-06-28 at 16 41 49

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻


          Adjust Send NFT layout for new tx flow

7c3d477

github-actions bot commented Jun 28, 2023 •

edited

Loading

Branch preview

✅ Deploy successful!

https://send_nft_ui--walletweb.review-wallet-web.5afe.dev

github-actions bot commented Jun 28, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

iamacook approved these changes

View reviewed changes

usame-algan merged commit ad441c9 into epic-tx-flow

usame-algan deleted the send-nft-ui branch

June 28, 2023 15:06

github-actions bot locked and limited conversation to collaborators

Member

katspaugh commented Jun 28, 2023

I think we need to increase the gap between NFTs and the recipient EthHashInfo. They look like they belong to the same list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet