Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show unlimited approval amount in readonly mode #2220

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 3, 2023

What it solves

Part of #2067

How this PR fixes it

  • Extracts readonly part from ApprovalEditorForm
  • Displays Unlimited approvals correctly in readonly mode

How to test it

  1. Open a Safe with queued approvals (unlimited and limited)
  2. Observe the values are displayed correctly

ToDos

  • Write tests for ApprovalEditor and the new components

Screenshots

Screenshot 2023-07-03 at 16 50 47 Screenshot 2023-07-03 at 16 50 58 Screenshot 2023-07-03 at 16 51 22

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu July 3, 2023 14:51
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Branch preview

✅ Deploy successful!

https://fix_approval_amount--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan requested a review from iamacook July 4, 2023 12:22
@usame-algan usame-algan merged commit e55c962 into epic-tx-flow Jul 4, 2023
@usame-algan usame-algan deleted the fix-approval-amount branch July 4, 2023 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants