Chore: escape quotes in release action #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Jul 5, 2023
.github/workflows/tag-release.yml
Outdated
| @@ -3,7 +3,7 @@ name: Tag & GitHub release | |||
| on: | |||
| pull_request_target: | |||
| branches: | |||
| - main | |||
| - dev | |||
There was a problem hiding this comment.
Why the change from main to dev?
There was a problem hiding this comment.
To test the PR, I'll revert it later.
katspaugh
force-pushed
the
fix-release
branch
9 times, most recently
from
5cddcb6
to
96e696b
Compare
Use printf Use a heredoc Use jq
|
After trying a few different things, the best solution was to pass the body as a variable instead of a file. For that, I've replaced our release action which also fixed the obsolete set_output warnings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
The release action pastes the contents of the RC pull request into a bash variable using an echo command, but if the PR description contains a quote it breaks the bash syntax.
E.g.