Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX flow] UI adjustments #2259

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[TX flow] UI adjustments #2259

merged 1 commit into from
Jul 10, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Adjusts AddressInput left spacing
  • Adjust Message Sign Button alignment
  • Remove unused variables/components
  • Align SendToBlock and SendAmountBlock
  • Change UpdateSafe title and subtitle
  • Hide mobile TxChecks messages if they are empty to remove the double gap
  • Hide Transaction details if tx is undefined

How to test it

Screenshots

Screenshot 2023-07-10 at 13 44 08 Screenshot 2023-07-10 at 13 46 25 Screenshot 2023-07-10 at 13 47 08

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Branch preview

✅ Deploy successful!

https://tx_flow_issues--walletweb.review-wallet-web.5afe.dev

<Grid container gap={1} alignItems="center">
<Grid container alignItems="center" sx={{ gap: 1 }}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using gap={1} results in 0px on mobile. We might need to update this in the MUI theme.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 13ba925 into epic-tx-flow Jul 10, 2023
@usame-algan usame-algan deleted the tx-flow-issues branch July 10, 2023 12:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants