Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix breaking tests #3312

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Tests: fix breaking tests #3312

merged 2 commits into from
Feb 22, 2024

Conversation

mike10ca
Copy link
Contributor

What it solves

How this PR fixes it

  • Fix breaking sidebar tests
  • Removed tests for depreciated functionality

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Feb 22, 2024

Copy link

github-actions bot commented Feb 22, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 22, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.03 MB (🟡 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Feb 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.6% (+0% 🔼)
11620/14783
🔴 Branches
56.91% (+0.05% 🔼)
2606/4579
🟡 Functions
63.45% (+0.01% 🔼)
1845/2908
🟡 Lines
79.97% (-0% 🔻)
10478/13102

Test suite run success

1402 tests passing in 192 suites.

Report generated by 🧪jest coverage report action from 5b24eaf

@mike10ca mike10ca marked this pull request as ready for review February 22, 2024 14:16
@@ -30,12 +30,6 @@ describe('Sidebar added sidebar tests', () => {
sideBar.verifySafeNameExists(newSafeName)
})

it('Verify a safe can be removed', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would skip it now and update to verify remove for the safes from watchlist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mike10ca mike10ca merged commit 14290d3 into dev Feb 22, 2024
13 checks passed
@mike10ca mike10ca deleted the fix-cy-sidebar-tests branch February 22, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants