Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Analytics] Set safe address during safe creation #3360

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Part of #3270

How this PR fixes it

In some cases it can happen that gtmSetSafeAddress is called too late after safe creation so that certain key events like safe_created do not contain the safeAddress. To solve this we additionally call gtmSetSafeAddress when the counterfactual safe creation is submitted.

How to test it

  1. Create a counterfactual safe
  2. Observe in the console that all events after pressing Create contain the safe address

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 28, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/new-safe/create 32.82 KB (🟡 +12 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.99% (-0% 🔻)
11522/14586
🔴 Branches 57.98% 2609/4500
🟡 Functions 64.09% 1847/2882
🟢 Lines
80.36% (-0% 🔻)
10382/12920
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.tsx
78.3% (-0.54% 🔻)
51.16% 72.73%
79% (-0.59% 🔻)

Test suite run success

1408 tests passing in 194 suites.

Report generated by 🧪jest coverage report action from 18c1a60

@usame-algan usame-algan merged commit 6961b9b into dev Feb 28, 2024
13 checks passed
@usame-algan usame-algan deleted the set-safe-address branch February 28, 2024 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants