Make redirection in a stream fashion

[parafish]

Hello,

I am trying out this fancy language detection script,
and I am actually thinking -
do you think it makes more sense to make
for line in sys.stdin.readlines():
into
for line in sys.stdin:

in langid.py ?

[saffsd]

Hi Zheyi

Thanks for the suggestion. Does this change the behavior of the program,
especially across versions of Python? Or is the default iterator over
sys.stdin actually sys.stdin.readlines throughout? I haven't actually been
able to find the relevant Python documentation.

Cheers,
Marco

On Tue, Mar 17, 2015 at 2:48 AM, Rong Zheyi notifications@github.com
wrote:

Hello,

I am trying out this fancy language detection script,
and I am actually thinking -
do you think it makes more sense to make
for line in sys.stdin.readlines():
into
for line in sys.stdin:

in langid.py ?

—
Reply to this email directly or view it on GitHub
#29.

[parafish]

I am not sure whether this would change the behavior of the program across versions of Python.
I raised this because readlines() will return a list, and this causes scalability problem - when the input is too big.

[jnothman]

fwiw, for line in sys.stdin: should be functionally identically to for line in sys.stdin.readlines(): but streaming.

[jnothman]

And I can't speak for anything before Python 2.3, but it worked then, I'm fairly certain.

[saffsd]

Fixed, thanks to tripleee, rongzhenyi and jnothman.