Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of appendToBody and introduce appendTo #1775

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

greendrake
Copy link

@greendrake greendrake commented Jun 4, 2023

Flexibility is needed as to where exactly the list gets appended to. Having only two options (to the body and right after the main element) is not enough.

The need to append the list somewhere else arose from this case where I needed to render the list inside a scrollable div within a <dialog> element. The list would hide behind the boundary of the scrollable div. To make it visible I had to append it to the dialog element directly.

This PR proposes getting rid of the appenToBody boolean and replacing it with a more general appendTo property. Seems like a breaking change, but hey, this is the next major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant