Fudge::Tasks::Task#initialize doesn't extract its options correctly.

[KevinBrowne]

Fudge::Tasks::Task#initialize copies and stores incoming arguments in the instance variable @args, and then extracts the options hash from the arguments and stores those in @options.

However, it extracts the options from the incoming arguments, not the copy in @args. Aside from the fact that #initialize alters its parameters—which is bad form—@args still retains the options hash, which is probably unintended.

This could affect a subclass that uses @args expecting—not unreasonably—that it doesn't include the options hash that was stored in @options.

Example (admittedly a little contrived):

# file: my_shell.rb
module Fudge
  module Tasks
    class MyShell
      def initialize(*args)
        super
        self.arguments = @args.join(' ')
      end
    end
    register MyShell
  end
end

# file: Fudgefile
build :default do
  task :my_shell, 'ls -l', foo: 'bar'
end

Running fudge with the above Fudgefile would result in

Running build default
Running task my_shell ls -l, {:foo=>"bar"}
ls: cannot access {:foo=: No such file or directory
Skipping callbacks...
Build FAILED!