Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legend_label doesn't work when plotting multiple functions at the same time #10514

Closed
jasongrout opened this issue Dec 22, 2010 · 14 comments
Closed

Comments

@jasongrout
Copy link
Member

This gives a legend:

plot(x,legend_label='test')+plot(x^2,legend_label='test')

but this doesn't:

plot([x,x^2], legend_label='test')

Apply attachment: trac_10514_multiple_function_legend.patch and attachment: trac_10514-reviewer.patch.

Depends on #12960

CC: @kcrisman

Component: graphics

Keywords: so40.5

Author: Douglas McNeil

Reviewer: Karl-Dieter Crisman

Merged: sage-5.1.beta4

Issue created by migration from https://trac.sagemath.org/ticket/10514

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

Attachment: trac_10514_multiple_function_legend.patch.gz

be less aggressive about pruning legend labels

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

Author: Douglas McNeil

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

Changed keywords from none to so40.5

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

comment:2

Patch attached. Note that this depends upon trac_12960-fix_legend.2.patch, not for the fix itself, but for the doctest.

@sagetrac-dsm sagetrac-dsm mannequin added the s: needs review label May 25, 2012
@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

Dependencies: 12960

@kcrisman
Copy link
Member

comment:4

Looking at this. Doug - note that it's best to use the #12960 syntax so one can click on the hyperlink created.

@kcrisman
Copy link
Member

Changed dependencies from 12960 to #12960

@kcrisman
Copy link
Member

comment:5

I'm adding a doctest for people to see this as well in the live documentation.

Why the extra blank lines?

Also, note that even this didn't work before.

sage: q1 = plot([sin(x)], legend_label='trig'); q1

which I assume why you did the test you did.

Reviewer patch coming up.

@kcrisman

This comment has been minimized.

@kcrisman
Copy link
Member

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

@jdemeyer
Copy link

jdemeyer commented Jun 2, 2012

comment:7

This conflicts with #11998.

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented Jun 2, 2012

comment:8

Am I the only one who finds it funny that a patch described as "be less aggressive about pruning legend labels" conflicts with a patch called "be more aggressive about pruning legend labels"?

I'll try letting #10514 take priority and modify #11998 to deal with it.

@jdemeyer
Copy link

Merged: sage-5.1.beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants