New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lots of minor docs and redundancy for riemann.pyx #10945
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
Regarding the documentation, thanks for pointing that out. I'll get on it. Since I'm working on this as a senior project, I appreciate any documentation/setup feedback since I can stick that under the category of "usability testing". I've separated the analytic tests under #10857. I'll get to work on that soon. With regards to the plotting, I plan to do some reworking of that whole area. I'm going to add options for parallelization of the grid computation. I also intend to make the display function modular so that different "color schemes" can be used. For example I want the interested user to be able to specify the bright/dark ranges. I also want to add an error plot that shows estimates of the numerical error. Now the reason I made my "clone" of complex_plot in the first place was to minimize the function call overhead by keeping it all in-house where I can take advantage of the cdef. However some of the work I want to do could be pretty general, thus it might be worth it to put it somewhere in the plot package. Thoughts? |
This comment has been minimized.
This comment has been minimized.
comment:5
Description updated. I'm not the Cython expert. But if you cc: Jason and Robert Bradshaw, you should get some good help :) I don't see why one couldn't cimport the complex plot, after all. Maybe not? Modularity is good, I don't think people will be plotting so very many of these as to worry about the millisecond it takes to import. |
comment:6
Correction, analytic tests are under #10957 |
This comment has been minimized.
This comment has been minimized.
comment:7
#11028 is taking care of the modularity and ColorPlot issues, I think. |
Reviewer: Karl-Dieter Crisman |
The Riemann mapping stuff is a great addition - excellent work!
But there are lots of minor problems that should be fixed. Here are some. Closing this ticket wouldn't require fixing them all, but if not, then explanations should be provided here and followup tickets (if needed) opened.
This is hard to follow, though I see what it says.
I
is supposed to demonstrate it works with lots of different complex types. I suggest the following.CC: @sagetrac-evanandel @jasongrout @wdjoyner @sagetrac-mvngu
Component: calculus
Keywords: riemann map complex plot
Reviewer: Karl-Dieter Crisman
Issue created by migration from https://trac.sagemath.org/ticket/10945
The text was updated successfully, but these errors were encountered: