Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cube(center, size=0.5) does not return a cube centered at center #11272

Closed
seblabbe opened this issue Apr 28, 2011 · 16 comments
Closed

cube(center, size=0.5) does not return a cube centered at center #11272

seblabbe opened this issue Apr 28, 2011 · 16 comments

Comments

@seblabbe
Copy link
Contributor

The center of the cube is affected by the argument size :

sage: c = cube(center=(10,10,10), size=0.5)              
sage: c.bounding_box()                            
((4.75, 4.75, 4.75), (5.25, 5.25, 5.25))          

The intended behavior is that the center is independant of the size:

sage: c = cube((10,10,10), size=0.5)              
sage: c.bounding_box()  
((9.75, 9.75, 9.75), (10.25, 10.25, 10.25))  

For the patchbot : Apply trac_11272-doctest.patch

Component: graphics

Keywords: cube

Author: Sébastien Labbé

Reviewer: Jeroen Demeyer

Merged: sage-4.7.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11272

@sagetrac-johanbosman
Copy link
Mannequin

sagetrac-johanbosman mannequin commented May 3, 2011

Attachment: trac_11272_cube_centre.patch.gz

@seblabbe
Copy link
Contributor Author

seblabbe commented May 4, 2011

Author: Johan Bosman

@seblabbe
Copy link
Contributor Author

seblabbe commented May 4, 2011

comment:2

Problem is fixed. All test passed in the directory sage/plot/plot3d. Documentation builds fine. Positive review. Thanks for the fix!

Sébastien

@seblabbe
Copy link
Contributor Author

seblabbe commented May 4, 2011

Reviewer: Sébastien Labbé

@jdemeyer
Copy link

comment:3

Needs to be rebased to sage-4.7.rc1

@sagetrac-johanbosman
Copy link
Mannequin

sagetrac-johanbosman mannequin commented May 11, 2011

comment:4

It seems to work properly in sage-4.7.rc1 without patches. Apparently the bug has already been fixed in another ticket.

@jdemeyer
Copy link

Changed author from Johan Bosman to none

@jdemeyer
Copy link

Changed reviewer from Sébastien Labbé to Sébastien Labbé, Johan Bosman

@jdemeyer
Copy link

comment:5

Duplicate of #10796.

@jdemeyer jdemeyer removed this from the sage-4.7.1 milestone May 11, 2011
@seblabbe
Copy link
Contributor Author

comment:6

I wonder if the doctest could be added to Sage anyway. Can we reopen the ticket for it?

Sébastien

@jdemeyer jdemeyer added this to the sage-4.7.1 milestone May 12, 2011
@jdemeyer jdemeyer reopened this May 12, 2011
@jdemeyer
Copy link

comment:8

Replying to @seblabbe:

I wonder if the doctest could be added to Sage anyway.

Good idea!

@seblabbe

This comment has been minimized.

@seblabbe
Copy link
Contributor Author

comment:9

Attachment: trac_11272-doctest.patch.gz

@jdemeyer
Copy link

Changed reviewer from Sébastien Labbé, Johan Bosman to Jeroen Demeyer

@jdemeyer
Copy link

Author: Sébastien Labbé

@jdemeyer
Copy link

Merged: sage-4.7.1.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants