-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDF/CDF eigenvalues: symmetric matrices, multiplicities #11608
Comments
Author: Rob Beezer |
This comment has been minimized.
This comment has been minimized.
Work Issues: rebase |
comment:3
Patch does not apply to 5.0.beta7 (see patchbot logs) |
Attachment: trac_11608-eigenvalues-symmetric-multiplicity-rebase.patch.gz Rebased on 5.0-beta10 |
This comment has been minimized.
This comment has been minimized.
Changed work issues from rebase to none |
comment:5
it's kind of weird that one coerces a complex matrix into real symmetric, but then treats it as a Hermitian one... |
comment:6
Despite the name, |
comment:7
The Any suggestions on making the docstring clearer? Maybe saying "then applies the algorithm for Hermitian matrices" should be stated differently? |
comment:8
On Fedora 16 x86_64, I get
ATLAS is from Fedora, CPU is a Sandy-Bridge i7 quad-core. Minor nitpicks while we are at it:
|
Reviewer: Volker Braun |
comment:9
Replying to @vbraun:
Thanks, I'll increase the tolerance and that should work better across platforms. You'd think I'd get the hang of this numerical stuff...
I'm not opposed, but other eigenvalue routines return mutable objects. I'd prefer to do one grand change across all matrix types, on a single-purpose ticket of its own.
Thanks for the nits. I'll make some changes right now. Rob |
comment:10
"Update" patch:
Rob |
This comment has been minimized.
This comment has been minimized.
comment:11
Looks great! |
comment:12
Replying to @vbraun:
Thanks, Volker! This was built on various 5.0-beta's, so I just double-checked that it applies, tests and builds on 5.0-rc0. Rob |
comment:14
The |
comment:15
Attachment: trac_11608-eigenvalues-symmetric-multiplicity-update-v2.patch.gz I thought this was OK and I just triple-checked, and I think it is OK. One change: made "warning" all capital letters, this is the only change to the v2 version of the update patch. The HTML documentation renders the warning blocks as they should. I'm going to move this back to positive review. Jeroen - please let me know if I am really missing something here. Thanks. Rob |
This comment has been minimized.
This comment has been minimized.
Changed keywords from none to sd40.5 |
comment:16
Yes, it looks okay now. I don't remember what precisely was wrong before. |
Merged: sage-5.1.beta4 |
As the summary says, this patch improves eigenvalues of matrices with double-precision floating-point entries.
eigh
routine for symmetric and Hermitian matrices.Apply:
CC: @jasongrout
Component: linear algebra
Keywords: sd40.5
Author: Rob Beezer
Reviewer: Volker Braun
Merged: sage-5.1.beta4
Issue created by migration from https://trac.sagemath.org/ticket/11608
The text was updated successfully, but these errors were encountered: