gfan 0.4plus [p1] fails to build with GCC 4.7.0

[nexttime]

This is due to a trivial programming error. I already have an spkg fixing this, along with a moderate clean-up of the spkg.

See #12751 for the GCC-4.7.0 metaticket.

---

New spkg: http://boxen.math.washington.edu/home/leif/Sage/spkgs/gfan-0.4plus.p3.spkg

md5sum: 2bb0b5f4cd0081c1af939294ba2e1859 gfan-0.4plus.p3.spkg

gfan-0.4plus.p3 (Leif Leonhardy, April 5th 2012)

• gfan 0.4plus [p1] fails to build with GCC 4.7.0 #12760: Fix erroneous unconditional export of CXXFLAG64, which is now in
  the first place always set, and used in the patched Makefile. (Also do not
  export CFLAG64, which is only used within spkg-install.)
• Add further TODOs... ;-)

gfan-0.4plus.p2 (Leif Leonhardy, March 25th 2012)

• gfan 0.4plus [p1] fails to build with GCC 4.7.0 #12760: Correct trivial C++ programming error to make gfan build with
  GCC 4.7.0.
• Clean up and beautify spkg-install.

CC: @sagetrac-mhampton @williamstein @sagetrac-mariah

Component: packages: standard

Keywords: spkg C++11 sd40.5

Author: Leif Leonhardy

Reviewer: Jeroen Demeyer

Merged: sage-5.0.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/12760

[nexttime]

Attachment: gfan-0.4plus.p1-p2.diff.gz

Diff between the previous spkg in Sage and my new p2 spkg. For reference / review only.

[nexttime]

Author: Leif Leonhardy

[jdemeyer]

comment:3

This should be reported upstream.

[nexttime]

comment:4

Replying to @jdemeyer:

This should be reported upstream.

That's one reason why I cc'ed the spkg maintainers... ;-)

Note that Gfan 0.4plus is of late 2009; Gfan 0.5 was released more than a year ago. Haven't checked whether the latter fixes the C++11 issues, but since it introduces new functionality (and probably also new bugs), I haven't tried using that.

[sagetrac-mhampton]

comment:5

Putting in Gfan 0.5 has been on my todo list for a long time but I haven't had a chance to concentrate on it. The whole interface could use a good overhaul. If no one else beats me to it I hope to tackle that this summer. The ticket for that is:

#11395

[nexttime]

comment:6

Wuuuuu... Cleaned up a bit too much.

Needs correction w.r.t. exporting CFLAG64 and especially CXXFLAG64 (which is used in the patched Makefile), otherwise build fails on ia64 and most probably also 32-bit systems.

[nexttime]

comment:8

Replying to @nexttime:

Needs correction w.r.t. exporting CFLAG64 and especially CXXFLAG64 (which is used in the patched Makefile), otherwise build fails on ia64 and most probably also 32-bit systems.

Now fixed in a new p3.

[nexttime]

Diff between the previous spkg in Sage and my new p3 spkg. For reference / review only.

[nexttime]

Attachment: gfan-0.4plus.p1-p3.diff.gz

Attachment: gfan-0.4plus.p2-p3.diff.gz

Diff between my p2 and my p3 spkg. For reference / review only.

[nexttime]

comment:9

From my updated SPKG.txt:

TODO:
 * Use `patch` to apply patches (then also add GNU patch to the dependencies).
 * Clean up `spkg-install` further w.r.t. installation etc.
 * Probably remove `CXXFLAG64` from the (patched) Makefile; instead put it
   into `LDFLAGS` and use these in the Makefile.
 * The Makefile is still suboptimal; e.g. Sage-specific values shouldn't be
   hardcoded into it.  That way we could provide a clean patch for upstream,
   and would later only have to change/set `make` variables in `spkg-install`,
   without the need to patch the Makefile at all for Sage.
   Also `CXXFLAGS` aren't used in, i.e. ignored by the current Makefile.

I'll probably fix some of these here later^TM as well, especially item 1, and perhaps also items 3 and 2, but because of #11395, I won't do much more at the moment.

[jdemeyer]

comment:10

You should make all files in src world-readable:

chmod -R ugo+r src

[nexttime]

comment:11

Replying to @jdemeyer:

You should make all files in src world-readable:

chmod -R ugo+r src

Well, these have been in before (and the respective files were of course user-readable, and they don't get installed anyway).

Anyway, fixed; new spkg, same place.

[SnarkBoojum]

comment:12

I managed to install :
2bb0b5f4cd0081c1af939294ba2e1859 gfan-0.4plus.p3.spkg
on my debian x86_64 box, using gcc 4.7.0.

[jdemeyer]

comment:13

Looks good to me.

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

Changed keywords from spkg C++11 to spkg C++11 sd40.5

[jdemeyer]

Merged: sage-5.0.1.rc1