-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatrixSpace is too eager to construct zero matrices #13012
Comments
Author: Andrey Novoseltsev |
Work Issues: doctests |
comment:3
Not yet finished, but I am doing the following:
If you object to anything on this list, please talk to me! I think that correctness of this approach is indirectly confirmed by the fact that only tests in |
Attachment: trac_13012_bug_with_zero_matrices.patch.gz |
comment:4
Summary of what was done:
Two files had to be adjusted:
|
comment:5
LGTM |
comment:6
Please fill in your real name in the Author / Reviewer fields. |
Reviewer: William Stein |
Changed work issues from doctests to none |
Merged: sage-5.1.beta5 |
This is a follow up to #10793 where it was prohibited to silently change dimensions of a matrix preserving the number of entries (e.g. 3x2 to 2x3). Here is the problem with zeros:
The last line should have raised an exception. I'm writing a patch.
CC: @vbraun @kcrisman @rbeezer
Component: linear algebra
Keywords: sd40.5
Author: Andrey Novoseltsev
Reviewer: William Stein
Merged: sage-5.1.beta5
Issue created by migration from https://trac.sagemath.org/ticket/13012
The text was updated successfully, but these errors were encountered: