Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine Polar Graphs #14631

Closed
nathanncohen mannequin opened this issue May 23, 2013 · 30 comments
Closed

Affine Polar Graphs #14631

nathanncohen mannequin opened this issue May 23, 2013 · 30 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented May 23, 2013

Thank youuuuuuUUUUUUUUUuuuuuu Brouwer !!! :-P

Nathann

P.S. : This patch "does not really" depend on #14589, but here is what happens when calling "is_strongly_regular" on a big graph. With the patch :

sage: g
Affine Polar Graph VO^+(10,2): Graph on 1024 vertices
sage: %time g.is_strongly_regular(parameters = True)
CPU times: user 3.30 s, sys: 0.00 s, total: 3.30 s
Wall time: 3.31 s
(1024, 527, 270, 272)

Without the patch

sage: %time g.is_strongly_regular(parameters = True)
CPU times: user 316.33 s, sys: 0.08 s, total: 316.41 s
Wall time: 317.20 s
(1024, 527, 270, 272)

Annnnnd the doctests that this patch adds are a bit faster as a result :-P

Depends on #16362

CC: @dimpase @sagetrac-azi @sagetrac-Slani

Component: graph theory

Author: Nathann Cohen, Dima Pasechnik

Branch/Commit: 3ef564e

Reviewer: Nathann Cohen, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/14631

@nathanncohen nathanncohen mannequin added this to the sage-5.11 milestone May 23, 2013
@nathanncohen

This comment has been minimized.

@nathanncohen nathanncohen mannequin added the s: needs review label May 23, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 23, 2013

Attachment: trac_14631.patch.gz

@nathanncohen

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented May 23, 2013

comment:4

How about "normal" polar space graphs? Any affine polar graph is (perhaps a quotients of) the subgraph induced on the non-neighbours of a vertex in a polar space graph.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 23, 2013

comment:5

How about "normal" polar space graphs? Any affine polar graph is (perhaps a quotients of) the subgraph induced on the non-neighbours of a vertex in a polar space graph.

Ahahah. Dima, I have NOooooooooo idea what "normal polar space graphs" are. I barely understand what this patch does in the first place. Why don't you give it a try, by the way ?

Nathann

@dimpase
Copy link
Member

dimpase commented May 23, 2013

comment:6

Replying to @nathanncohen:

How about "normal" polar space graphs? Any affine polar graph is (perhaps a quotients of) the subgraph induced on the non-neighbours of a vertex in a polar space graph.

Ahahah. Dima, I have NOooooooooo idea what "normal polar space graphs" are.

I sent you a link to a text about them, didn't I? Here is another link:
http://www.win.tue.nl/~aeb/graphs/srghub.html
Most of the graphs described there are of this type (expect the Grassmann graphs, E_6, and the rest of low-dimensional examples).

I barely understand what this patch does in the first place. Why don't you give it a try, by the way ?

I have about 10 other things I must work on now (if not last month or year :)), and organization of this:
http://web.spms.ntu.edu.sg/~dima/IMS2013/
And I don't even have a fixed job, as you know, so you don't feel the pressure I do feel from this side...

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 25, 2013

comment:8

Made it a Git branch, as I need to use it.

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 25, 2013

Branch: u/ncohen/14631

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

a9faba0trac #14631: Affine Polar Graphs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2013

Commit: a9faba0

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:12

With #16362 one can construct VO(n,q,) by merely taking the subgraph induced on non-neighbours of a vertex in
OrthogonalPolarGraph(n+2,q,<sign>). I don't insist on rewriting the code, but this should at least be mentioned in the docs somewhere.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 18, 2014

comment:13

With #16362 one can construct VO(n,q,) by merely taking the subgraph induced on non-neighbours of a vertex in
OrthogonalPolarGraph(n+2,q,<sign>). I don't insist on rewriting the code, but this should at least be mentioned in the docs somewhere.

That's what happens when a patch stays in "needs_review" for one year.

I will add a commit in a second :-P

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a1ec9b5trac #14631: Merged with 6.3.beta1
6adc14btrac #16362: Polar Graph
f1e4fb3just a small pep8 cleanup
e3c4aaatrac #16362: Reviewer's comments
0089d6ctrac #16362: Broken documentation
c5cc1d9trac #14631: Merged with #16362
e725be9trac #14631: Note added

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2014

Changed commit from a9faba0 to e725be9

@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:15

well, my comment on this fact is about a year old :–)


New commits:

a1ec9b5trac #14631: Merged with 6.3.beta1
6adc14btrac #16362: Polar Graph
f1e4fb3just a small pep8 cleanup
e3c4aaatrac #16362: Reviewer's comments
0089d6ctrac #16362: Broken documentation
c5cc1d9trac #14631: Merged with #16362
e725be9trac #14631: Note added

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 18, 2014

comment:16

I don't get a word of what you said in this comment.

Nathann

@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:17

Replying to @nathanncohen:

I don't get a word of what you said in this comment.

It must be then pure coincidence that I mention http://www.win.tue.nl/~aeb/graphs/srghub.html there (the link mentioned by you in #16362) :P

@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:18

Affine Polar Graph page should be
Affine Polar Graphs page

@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:19

This code has the same potential bug as mentioned in here.
Please fix.

@dimpase
Copy link
Member

dimpase commented May 18, 2014

comment:20

Also, for consistency with #16362, the function AffinePolarGraph should be renamed AffineOrthogonalPolarGraph.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 19, 2014

Changed dependencies from #14589 to #16362

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 19, 2014

comment:21

Done.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2014

Changed commit from e725be9 to 4f82fa5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 19, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

257082dtrac #14631: Reviewer's comments
272e18ftrac #16362: Broken doc 2
4f82fa5trac #14631: Merged with #16362

@dimpase
Copy link
Member

dimpase commented May 19, 2014

Changed branch from u/ncohen/14631 to u/dimpase/14631

@dimpase
Copy link
Member

dimpase commented May 19, 2014

Changed commit from 4f82fa5 to 3ef564e

@dimpase
Copy link
Member

dimpase commented May 19, 2014

comment:24

if you're happy with my changes please set this to positive review!


New commits:

3ef564elibGAPification

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 19, 2014

comment:25

Well, given that it still passes tests... :-)

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented May 19, 2014

Reviewer: Nathann Cohen, Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented May 21, 2014

Changed branch from u/dimpase/14631 to 3ef564e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants