New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zeromq and pyzmq to recent version and new git layout #16455
Comments
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:4
Sebastien, i modified the patch that could not be applied anymore, please can you check whether this still works on Darwin ? |
Changed keywords from none to ipython |
Author: Thierry Monteil |
This comment has been minimized.
This comment has been minimized.
comment:5
For what it is worth, I strongly support including IPython notebook (and deps) in Sage standard. -- William |
comment:6
I get this after installing your branch :
|
comment:7
The tarball you found at |
comment:8
Replying to @sagetrac-tmonteil:
But the above put the tarball in the upstream directory. So that means I can do :
|
comment:9
The first command will lead to an error, since it not only tries to download the tarball in upstream/, but also tries to install it as a sage spkg, explaining your error, hence you should consider using wget ot curl for that part of the review. Of course, once the ticket is merged, there is no need to download the tarball manually since sage will find it at http://sagemath.org/packages/upstream/ That said, after that error, the second command should work, since zeromq-4.0.4.tar.gz is now in the upstream/ directory. |
comment:10
Ok, so I just tested and it does work on my machine. I also managed to open the ipython notebook with these. I also tested without the buildutils patch on pyzmq, and |
comment:11
OK, once you confirm that the patch is not needed anymore, i will remove it from the branch. |
comment:12
With the following modifications:
I confirm that it works:
|
comment:13
remove the patch for pyzmq |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Sébastien Labbé |
comment:16
One question before giving a positive review. Can the spkg-install of pyzmq check that zeromq spkg was installed before? But maybe it is not a good idea, and it is better to let the installation breaks by itself.... |
comment:17
To my understanding, the dependencies are set via the That said, since those packages are optional for more than one year and many people want them to become standard, i plan to make a ticket for that. |
comment:18
We don't have a dependency mechanism for optional packaeges yet. But please don't roll your own just for zeromq... |
comment:20
Some optional packages do some dependency checking in their spkg-install, for example the p_group_cohomology package does this: SMALL_GROUPS=`echo "SmallGroup(13,1); quit;" | gap -b -T | grep "13"`
if [ "$SMALL_GROUPS" = "" ]; then
echo "It seems that GAP's SmallGroups library is missing."
echo "One way to install it is by doing"
echo " sage: install_package('database_gap')"
echo "in a Sage session."
exit 1
fi Will installation of pyzmq fail gracefully if zeromq is missing, or is it better to have a check like this? |
comment:21
someone installing pyzmq before zeromq will get something like :
|
comment:22
Anyway, these two packages are aimed to become standard soon if I understand correctly, so their dependencies will be set via the |
comment:23
delete invisible space |
Changed reviewer from Sébastien Labbé to Sébastien Labbé |
Changed branch from u/tmonteil/update_zeromq_and_pyzmq_to_recent_version_and_new_git_layout to |
Changed commit from |
comment:25
Who confirmed that this was useless? This will still not work on older Macs - see the actual note that was in the SPKG.txt!!!
And now that this is standard with all the big changes at the end of 6.4, it breaks some of them. And since the machine I am currently trying to build Sage on does not have git, nor has git built yet, I will have to type this entire patch in BY HAND, or nearly so. |
comment:26
Me. My machine is a MacOSX 10.5.8. I have read that note in the SPKG. When I did the review, I confirmed that the patch was needed with the earlier spkg but not with the new one which I gave a positive review. I am sorry for having cause you trouble today. Maybe we should add more documentation in the patch to re-add saying for what machine exactly it is mandatory. Because to me, it is not needed for 10.5.8 anymore. Sébastien |
comment:27
Oh! And indeed if I had been more careful I would have seen that you were responsible for #13313 and so knew what you were talking about.
I apologize also, because I was snippy in my comment. I had left the machine compiling all night, only to discover this (relatively early) error. I think that the question is in when they add these flags. What do you get for
on my Lion computer (10.7) I get |
comment:28
@kcrisman: I pinged Sebastien on that ticket because he was the author of the patch and i have no mac to test. If there is some problem with some particular version of OSX, i think this is worth opening a new ticket for that issue now, or the information you will provide on the current thread will be less visible there. |
comment:29
Naturally, just wanting to confirm before opening a new ticket. See #17510. |
comment:30
No problem. I should have thought of adding you in cc of this ticket by the time of the review, since I remember that #13313 was also useful for you. |
comment:31
Replying to @kcrisman:
When I reported that (cf the link to sage-devel in #13313) I tried that on an PPC OSX 10.5.8 machine, which is 32-bit all the way. I don't think I did build anything with SAGE64. |
The packages zero an pyzmq are required to let IPython notebook work within Sage. There seems to be a consensus to have those as standard packages. See also #16053.
The upstream tarballs can be found at :
CC: @seblabbe @vbraun @williamstein @dimpase
Component: packages: optional
Keywords: ipython
Author: Thierry Monteil
Branch:
184da0c
Reviewer: Sébastien Labbé
Issue created by migration from https://trac.sagemath.org/ticket/16455
The text was updated successfully, but these errors were encountered: