Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gentoobj and rename it to gen_to_sage #21807

Closed
jdemeyer opened this issue Nov 3, 2016 · 43 comments
Closed

Move gentoobj and rename it to gen_to_sage #21807

jdemeyer opened this issue Nov 3, 2016 · 43 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Nov 3, 2016

The function sage.libs.cypari2.gen.gentoobj returning Sage objects is moved to sage.libs.pari.sage_convert.gen_to_sage.

CC: @defeo @jpflori @pjbruin

Component: interfaces

Keywords: atelierpari2017

Author: Vincent Delecroix

Branch/Commit: 8828867

Reviewer: Luca De Feo

Issue created by migration from https://trac.sagemath.org/ticket/21807

@jdemeyer jdemeyer added this to the sage-7.5 milestone Nov 3, 2016
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Create a SagePariInstance class Move gentoobj and rename it to gentosage Nov 3, 2016
@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Nov 4, 2016

Dependencies: #21820

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

Author: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

Branch: u/vdelecroix/21807

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

Changed dependencies from #21820 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

44b755821807: gentoobj -> gentosage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Commit: 44b7558

@videlec

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8b67f8021807: gentoobj -> gentosage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Changed commit from 44b7558 to 8b67f80

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

Changed keywords from none to atelierpari2017

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:9

We hav gen_to_integer versus gentoobj. What convention should we use? I am in favor of Sage's one: gen_to_sage. What do you think?

@defeo
Copy link
Member

defeo commented Jan 10, 2017

comment:10

gen_py.py has been deprecated 12 months ago. We might as well drop it.

@defeo
Copy link
Member

defeo commented Jan 10, 2017

comment:11

as for gentosage vs gen_to_sage, it's all the same to me.

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:12

Replying to @defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

I will do it here.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

791c1c221807: t_RAT does not exist (documentation issue)
706b3be21807: remove gen_py.py
29f83ed21807: gentosage -> gen_to_sage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Changed commit from 8b67f80 to 29f83ed

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:15

Replying to @defeo:

as for gentosage vs gen_to_sage, it's all the same to me.

I changed it to gen_to_sage in my last commit.

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:24

No more compilation troubles... sorry

@jdemeyer
Copy link
Author

comment:25

Replying to @defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

This might break the pickle jar. Be sure to run doctests...

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:26

Replying to @jdemeyer:

Replying to @defeo:

gen_py.py has been deprecated 12 months ago. We might as well drop it.

This might break the pickle jar. Be sure to run doctests...

Indeed. I propose to get rid of gen_py.py in another ticket.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c0ac79221807: gentoobj -> gentosage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Changed commit from d173a7b to c0ac792

@jdemeyer
Copy link
Author

comment:29

Don't deprecate sage.libs.cypari2.gentoobj, just remove it. We don't want Sage deprecations in cypari2.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Changed commit from c0ac792 to 375658c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

375658c21807: remove gentoobj (that was just a deprecated alias)

@videlec
Copy link
Contributor

videlec commented Jan 10, 2017

comment:31

done

@defeo
Copy link
Member

defeo commented Jan 11, 2017

Changed branch from u/vdelecroix/21807 to u/defeo/21807

@jdemeyer
Copy link
Author

New commits:

8828867Python 3 compatibility in doctests

@jdemeyer
Copy link
Author

Changed commit from 375658c to 8828867

@defeo
Copy link
Member

defeo commented Jan 12, 2017

comment:34

I'm happy, Patchbot's happy, everyone's happy!

@vbraun
Copy link
Member

vbraun commented Jan 18, 2017

Changed branch from u/defeo/21807 to 8828867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants