Change gen.python() to return Python objects #21808

jdemeyer · 2016-11-03T14:18:56Z

Currently, gen.python() is the same as gen.sage() which returns Sage objects. There should be a pure Python version, returning Python objects.

We implement the following conversions inside a gen_to_python function

t_INT -> int or long
t_REAL -> float
t_COMPLEX -> complex
t_FRAC -> fraction
t_INFINITY -> float
t_STR -> str
t_VEC, t_COL -> list
t_MAT -> list of lists

For all other types, the function raises a NotImplementedError.

Depends on #21807

CC: @defeo

Component: interfaces

Keywords: atelierpari2017

Author: Vincent Delecroix

Branch/Commit: ee54f07

Reviewer: Luca De Feo

Issue created by migration from https://trac.sagemath.org/ticket/21808

The text was updated successfully, but these errors were encountered:

jdemeyer · 2016-11-04T18:28:08Z

Dependencies: #21820

videlec · 2017-01-09T17:12:50Z

comment:2

I would like to implement a gentopython function from the current gentoobj however very few types would be supported. Unless we allow third party Python modules such as gmpy, mpmath python-flint, etc

I guess the best solution would be to support only t_INT, t_VEC, t_COL, t_VECSMALL and further extend the capabilities once this is moved as a Python module. What do you think?

jdemeyer · 2017-01-09T21:37:55Z

comment:3

Why not:

t_REAL -> float
t_COMPLEX -> complex
t_FRAC -> fraction
t_STR -> str
t_MAT -> list of lists
t_INFINITY -> float

videlec · 2017-01-10T09:36:25Z

Changed dependencies from #21820 to #21807

videlec · 2017-01-10T09:36:25Z

Changed keywords from none to atelierpari2017

defeo · 2017-01-10T11:06:17Z

comment:6

why not t_VEC -> list?

videlec · 2017-01-10T13:08:22Z

comment:7

Replying to @defeo:

why not t_VEC -> list?

Indeed. And t_COL.

videlec · 2017-01-10T13:40:00Z

Commit: 7fbc989

videlec · 2017-01-10T13:40:00Z

Author: Vincent Delecroix

videlec · 2017-01-10T13:40:00Z

Branch: u/vdelecroix/21808

videlec · 2017-01-10T13:40:00Z

New commits:

`8b67f80`	`21807: gentoobj -> gentosage`
`791c1c2`	`21807: t_RAT does not exist (documentation issue)`
`706b3be`	`21807: remove gen_py.py`
`29f83ed`	`21807: gentosage -> gen_to_sage`
`a3624b1`	`21807: copyright notice`
`7fbc989`	`21808: gen_to_python`

sagetrac-git · 2017-01-10T14:14:27Z

Changed commit from 7fbc989 to d7ab7f6

sagetrac-git · 2017-01-10T14:14:27Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`c0ac11b`	`21807: gentosage -> gen_to_sage`
`d173a7b`	`21807: copyright notice`
`d7ab7f6`	`21808: gen_to_python`

videlec · 2017-01-10T14:15:14Z

comment:11

rebased on the correct #21807

sagetrac-git · 2017-01-10T14:55:36Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`c0ac792`	`21807: gentoobj -> gentosage`
`6bd0667`	`21808: gen_to_python`

sagetrac-git · 2017-01-10T14:55:36Z

Changed commit from d7ab7f6 to 6bd0667

videlec · 2017-01-10T14:56:19Z

comment:13

rebased on #21807 and all tests pass in libs/pari, libs/cypari2 and structure/.

jdemeyer · 2017-01-10T15:40:20Z

comment:15

(Edit: wrong ticket)

sagetrac-git · 2017-01-10T15:50:03Z

Changed commit from 6bd0667 to 2c83d77

sagetrac-git · 2017-01-10T15:57:08Z

Changed commit from 2c83d77 to 442299f

sagetrac-git · 2017-01-10T15:57:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`442299f`	`21808: remove the TODO comment`

sagetrac-git · 2017-01-10T15:58:48Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dade42d`	21808: remove the `_eval_` method

sagetrac-git · 2017-01-10T15:58:48Z

Changed commit from 442299f to dade42d

sagetrac-git · 2017-01-10T16:28:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5a0311c`	`21808: remove "locals" + documentation`

sagetrac-git · 2017-01-10T16:28:04Z

Changed commit from dade42d to 5a0311c

sagetrac-git · 2017-01-10T16:32:58Z

Changed commit from 5a0311c to 8fb6000

sagetrac-git · 2017-01-10T16:32:58Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`8fb6000`	`21808: remove "locals" + documentation`

sagetrac-git · 2017-01-10T16:45:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`6ddac6c`	`21808: change .python() -> .sage() in sage/matrix/`

sagetrac-git · 2017-01-10T16:45:19Z

Changed commit from 8fb6000 to 6ddac6c

sagetrac-git · 2017-01-10T17:00:59Z

Branch pushed to git repo; I updated commit sha1. New commits:

`01ad2d8`	`21808: .python() -> .sage() in sage/modular/`
`79397fb`	`21808: some more .python() -> .sage() conversions`

sagetrac-git · 2017-01-10T17:00:59Z

Changed commit from 6ddac6c to 79397fb

sagetrac-git · 2017-01-10T19:15:03Z

Changed commit from 79397fb to 183588e

sagetrac-git · 2017-01-10T19:15:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`183588e`	`21808: fix some more .python() .sage()`

videlec · 2017-01-10T20:08:50Z

comment:27

all tests pass on my computer

defeo · 2017-01-11T14:12:26Z

Changed branch from u/vdelecroix/21808 to u/defeo/21808

sagetrac-git · 2017-01-11T14:21:41Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`8fb6000`	`21808: remove "locals" + documentation`
`6ddac6c`	`21808: change .python() -> .sage() in sage/matrix/`
`01ad2d8`	`21808: .python() -> .sage() in sage/modular/`
`79397fb`	`21808: some more .python() -> .sage() conversions`
`183588e`	`21808: fix some more .python() .sage()`
`87b6ac3`	`Merge branch 't/21807/21807' into HEAD`
`ee54f07`	`Python 3 compatibility in doctests`

sagetrac-git · 2017-01-11T14:21:41Z

Changed commit from 183588e to ee54f07

videlec · 2017-01-11T22:41:10Z

comment:30

And now patchbot is happy ;-)

defeo · 2017-01-12T10:38:30Z

comment:31

I'm happy, Patchbot's happy, everyone's happy!

defeo · 2017-01-12T10:38:30Z

Reviewer: Luca De Feo

vbraun · 2017-01-18T20:39:22Z

Changed branch from u/defeo/21808 to ee54f07

jdemeyer added this to the sage-7.5 milestone Nov 3, 2016

jdemeyer added c: interfaces labels Nov 3, 2016

This comment has been minimized.

Sign in to view

videlec modified the milestones: sage-7.5, sage-7.6 Jan 10, 2017

This comment has been minimized.

Sign in to view

videlec added the s: needs review label Jan 10, 2017

This comment has been minimized.

Sign in to view

defeo added s: positive review and removed s: needs review labels Jan 12, 2017

vbraun removed the s: positive review label Jan 18, 2017

vbraun closed this as completed in c302948 Jan 18, 2017

This was referenced Apr 29, 2017

Move the Sage <-> PARI interface to a stand-alone package CyPari #20238

Closed

Rename PariInstance -> Pari #22183

Closed

Rename gen -> Gen #22185

Closed

Change gen.python() to return Python objects #21808

Change gen.python() to return Python objects #21808

Comments

jdemeyer commented Nov 3, 2016

jdemeyer commented Nov 4, 2016

videlec commented Jan 9, 2017

jdemeyer commented Jan 9, 2017

videlec commented Jan 10, 2017

videlec commented Jan 10, 2017

This comment has been minimized.

defeo commented Jan 10, 2017

This comment has been minimized.

videlec commented Jan 10, 2017

This comment has been minimized.

videlec commented Jan 10, 2017

videlec commented Jan 10, 2017

videlec commented Jan 10, 2017

videlec commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

videlec commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

videlec commented Jan 10, 2017

This comment has been minimized.

jdemeyer commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

sagetrac-git mannequin commented Jan 10, 2017

This comment has been minimized.

videlec commented Jan 10, 2017

defeo commented Jan 11, 2017

sagetrac-git mannequin commented Jan 11, 2017

sagetrac-git mannequin commented Jan 11, 2017

videlec commented Jan 11, 2017

defeo commented Jan 12, 2017

defeo commented Jan 12, 2017

vbraun commented Jan 18, 2017