Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython patches to fix various issues with binding=True #23155

Closed
jdemeyer opened this issue Jun 7, 2017 · 13 comments
Closed

Add Cython patches to fix various issues with binding=True #23155

jdemeyer opened this issue Jun 7, 2017 · 13 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2017

Apply these two patches:

This is needed for #22747.

Upstream: Fixed upstream, but not in a stable release.

Component: packages: standard

Branch/Commit: u/jdemeyer/ticket/23155 @ 091657d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/23155

@jdemeyer jdemeyer added this to the sage-8.0 milestone Jun 7, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2017

Branch: u/jdemeyer/ticket/23155

@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2017

New commits:

2e2339bAdd Cython patch to fix decorators with binding=True

@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2017

Commit: 2e2339b

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

e09e3e0Add Cython patch to fix method calls with binding=True

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2017

Changed commit from 2e2339b to e09e3e0

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add Cython patch to fix binding=True with decorators Add Cython patch to fix various issues with binding=True Jun 7, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2017

Changed commit from e09e3e0 to 091657d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

091657dAdd Cython patch to fix method calls with binding=True

@jdemeyer jdemeyer changed the title Add Cython patch to fix various issues with binding=True Add Cython patches to fix various issues with binding=True Jun 7, 2017
@jdemeyer
Copy link
Author

Changed author from Jeroen Demeyer to none

@jdemeyer
Copy link
Author

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Author

comment:8

Both have been merged upstream. Given the upcoming Cython release (see #23360), I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant