Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast iterator for set partitions with given block sizes #25865

Closed
mantepse opened this issue Jul 17, 2018 · 23 comments
Closed

fast iterator for set partitions with given block sizes #25865

mantepse opened this issue Jul 17, 2018 · 23 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@mantepse
Copy link
Contributor

As promised in #25462 comment:56, this provides a fast iterator for set partitions with given block sizes, via linear extensions of a certain poset.

Depends on #25462
Depends on #25864

CC: @tscrim @kevindilks

Component: combinatorics

Author: Martin Rubey

Branch/Commit: 027b299

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25865
@mantepse mantepse added this to the sage-8.4 milestone Jul 17, 2018
@mantepse
Copy link
Contributor Author

Branch: u/mantepse/fast_iterator_for_set_partitions_with_given_block_sizes

@mantepse
Copy link
Contributor Author

Author: Martin Rubey

@mantepse
Copy link
Contributor Author

Dependencies: #25462, #25864

@mantepse
Copy link
Contributor Author

Commit: 84ba2c8

@mantepse

This comment has been minimized.

Sign in to view
@mantepse
Copy link
Contributor Author

Last 10 new commits:

ca293e3avoid itertools and modify docstring
594ace9Merge commit 'ca293e3' into public/25462
9c5298dmake doctests more independent of ordering
91e8d5cMerge commit '9c5298d' into public/25462
ce2962brestore richer doc tests
ba08ff3reviewer's comments
95ce20fprovide iterators which return lists of lists
d2e0e6einline a computation by reviewer's request
7524eb5Merge branch 'public/25462' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes
84ba2c8a faster iterator for set partitions with given block sizes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8050b00create graphs.LinearExtensions.__iter__, adapt a few methods and doctests
f1705d8fix mistake in initialisation of LinearExtensions and adapt doctests
0765e7fMerge branch 'u/mantepse/make_linearextensions_an_iterator' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes
78bb5c8fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2018

Changed commit from 84ba2c8 to 78bb5c8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

9278b8eMerge branch 'develop' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Changed commit from 78bb5c8 to 9278b8e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Changed commit from 9278b8e to 746113a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f9a7227fix pyflakes import statements
84aad72deprecate LinearExtensions
d8795fbdo not sort in methods
dcb8fe3Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator
8512ff7Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator
9ec826ffix doctests
4ec1900remove sorting in doctests by reviewer's request
cca1616Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator
42dad7dMerge branch 't/25864/make_linearextensions_an_iterator' into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes
746113amake iter work with arbitrary base sets, adapt doctests, remove old iterator, deprecate property

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Changed commit from 746113a to add1d3f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 25, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

add1d3fmake iterator much faster, adapt doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 26, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

027b299remove unused imports, fix remaining doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 26, 2018

Changed commit from add1d3f to 027b299

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2019

comment:10

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2019

Reviewer: Travis Scrimshaw

@tscrim tscrim modified the milestones: sage-8.4, sage-8.6 Jan 3, 2019
@mantepse
Copy link
Contributor Author

mantepse commented Jan 3, 2019

comment:11

Thank you!

@jdemeyer
Copy link

jdemeyer commented Jan 4, 2019

comment:12

Did anyone check for conflicts with #26917?

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2019

comment:13

Replying to @jdemeyer:

Did anyone check for conflicts with #26917?

I did not. Martin, did/could you check? If there is a conflict, feel free to set back to a positive review once you push the merge.

@embray
Copy link
Contributor

embray commented Jan 15, 2019

comment:14

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

@embray embray modified the milestones: sage-8.6, sage-8.7 Jan 15, 2019
@vbraun
Copy link
Member

vbraun commented Jan 23, 2019

Changed branch from u/mantepse/fast_iterator_for_set_partitions_with_given_block_sizes to 027b299

@vbraun vbraun closed this as completed in 35931ca Jan 23, 2019
@fchapoton fchapoton mentioned this issue Apr 8, 2023
Merged
5 tasks
vbraun pushed a commit that referenced this issue Apr 13, 2023
gh-35458: remove old deprecated properties in set_partition + pep8 cl…
91949e3 
…eanup

    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

This removes two old deprecated properties in `set_partition.py`,
replaced by methods in #25462 and #25865.

Also performs a pycodestyle cleanup of the modified file.

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35458
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
5 participants
@embray @vbraun @tscrim @jdemeyer @mantepse