Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old deprecated properties in set_partition + pep8 cleanup #35458

Merged
merged 1 commit into from Apr 13, 2023
Merged

remove old deprecated properties in set_partition + pep8 cleanup #35458

merged 1 commit into from Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Apr 8, 2023 •
edited

📚 Description

This removes two old deprecated properties in set_partition.py, replaced by methods in #25462 and #25865.

Also performs a pycodestyle cleanup of the modified file.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 263cce1

dcoudert
dcoudert approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov warnings can be considered in a future PR.

LGTM.

@vbraun vbraun merged commit 91949e3 into sagemath:develop Apr 13, 2023
9 of 10 checks passed
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
@fchapoton fchapoton deleted the remove_deprecation_in_set_partition branch July 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe