New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to FreeType 2.9.1 #27169
Comments
Branch: u/slelievre/t/27169 |
This comment has been minimized.
This comment has been minimized.
comment:2
To upgrade, I downloaded the new tarball to
New commits:
|
Commit: |
comment:3
The Someone knowledgeable should check if that is still needed.
|
comment:4
According to FreeType documentation,
Not sure if this double licensing was already the case when |
comment:5
Yes, I thought I did the harfbuzz thing 4afa106 That's from 2015, I am hoping it is fixed but I cannot dig into it right now. For the license I think we should update |
comment:6
There is a mirror of freetype on github so I could check. And the answer is yes. harfbuzz minimal version detection is now done. So it is fixed. |
comment:7
Something is not right - check that one gets freetype-config script installed to SAGE_LOCAL/bin. This is needed for other libs using freetype, and seems to be broken by this update. |
comment:8
Thanks François for mentioning that the FreeType code repo is mirrored The FreeType README
According to the
It might be worth going through the other changes listed there. I feel a little bit out of my depth here, if someone wants to take over. |
comment:9
I've got past this issue by diff --git a/build/pkgs/freetype/spkg-install b/build/pkgs/freetype/spkg-install
index 49450d4944..b2713060ac 100644
--- a/build/pkgs/freetype/spkg-install
+++ b/build/pkgs/freetype/spkg-install
@@ -1,7 +1,7 @@
cd src
# Disabling harfbuzz until upstream properly check for suitable version
-GNUMAKE=${MAKE} sdh_configure --with-harfbuzz=no
+GNUMAKE=${MAKE} sdh_configure --enable-freetype-config
sdh_make
sdh_make_install (no need to worry about I think the rest of updates are enhancements, we don't need to worry about them. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Samuel Lelièvre, Dima Pasechnik |
comment:11
I edited New commits:
|
comment:12
I can't push to your personal branch. As this is the only difference so far, and hopefully stays this way, I'd rather let you add this change yourself. |
comment:13
OK, this also appears to fix #27163 Subject to adding patch in comment 9, positive review. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Should have used a public branch, sorry. Added your change now. |
Reviewer: François Bissey, Dima Pasechnik |
comment:16
Cc-ing Andrey Novoseltsev in case this might impact SageCell. |
comment:17
Looks good to me. Let's see if Andrey has something to say before putting it to positive review. |
comment:18
I hope that SageMathCell will not be affected, so please go ahead! |
comment:21
On Debian
and
|
comment:22
Replying to @EmmanuelCharpentier: Please forget that. Apparently, the tarbal download didn't work an I didn't see that. I'll have to retry. My most sincere apologies... [ Lots of bollocks : Snip... ] |
comment:23
You can always check what version of freetype you have installed in Sage by calling, at
by the way, no need to post lists of CRAN mirrors---you probably also know
would automatically get to the repo of your choice. |
comment:24
After squelching my coroirate firewall's BS and correctly installing the source tarball, I now get graphical capabilities with both R 3.4.4 and R 3.5.3 ; in both cases, teh R Cairo package installs correctly.
|
comment:25
Replying to @dimpase:
I didn't knew that. Thanks for the tip !
Indeed. I was typing too fast...
Indeed also. But the damn firewall tries to nanny us, which seriously interferes with the availability of a given site, changing with time... So I tend to systematically let R search for a suitable repository. What troubles me more is that |
comment:26
Forgot to warn that downloading from that url works in a browser but not with |
This comment has been minimized.
This comment has been minimized.
comment:27
Replying to @EmmanuelCharpentier:
Sage's dependencies resolution is far from ideal. The first thing I'd to to test a new package is to run |
Changed branch from u/slelievre/t/27169 to |
This ticket is to upgrade to FreeType 2.9.1.
Note that downloading from that url works in a browser but not with
curl -O $URL
which results in a zero byte file. Some redirection must be going on.Our last upgrade was to FreeType 2.8.1 in #24240
(merged in SageMath 8.2.beta0).
This might help with #27163, see comment 27 there.
CC: @antonio-rojas @EmmanuelCharpentier @dimpase @embray @kiwifb @timokau @infinity0 @novoselt @slel @tobihan
Component: packages: standard
Keywords: upgrade, freetype
Author: Samuel Lelièvre, Dima Pasechnik
Branch/Commit:
4c0c338
Reviewer: François Bissey, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/27169
The text was updated successfully, but these errors were encountered: