New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow parametric_plot and parametric_plot3d to take a vector as input #3133
Comments
comment:1
As a test, the following should work:
|
comment:2
The error is different now too:
|
comment:3
See #3315 for another input format that parametric_plot should take (functions returning tuples) |
comment:4
Attachment: trac-3133-parametric_plot-vector.patch.gz |
comment:5
Positive review of the content. My only concern is that the "internal" functions now have their names changed so we could possibly have to deprecate the non-underscored versions of them (however, only using the underscored ones). What do you think? Probably it's unnecessary, since they were never in the global namespace. |
comment:6
Replying to @kcrisman:
I thought it was probably okay since they were not in the global namespace and their documentation said that they were internal functions. I was just making them more conventional internal functions. If you'd like I can make them deprecated. Let me know. I think it's okay in this case to just change the names. |
Author: Jason Grout |
comment:7
My thoughts exactly, actually - just wanted to see what your reasoning was. |
Reviewer: Karl-Dieter Crisman |
Merged: Sage 4.1.2.alpha2 |
comment:8
See #6963 for a follow up to this ticket. |
CC: @kcrisman @jasongrout
Component: graphics
Author: Jason Grout
Reviewer: Karl-Dieter Crisman
Merged: Sage 4.1.2.alpha2
Issue created by migration from https://trac.sagemath.org/ticket/3133
The text was updated successfully, but these errors were encountered: