New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
follow up to #3133: fix ReST formatting #6963
Comments
depends on #3133 |
Author: Minh Van Nguyen |
comment:1
Attachment: trac_6963-rest.patch.gz |
comment:2
I didn't apply this, but I think it's probably simple enough that I can give it positive review just by looking at it. Minh---I would have thought that this was a change small enough that you could have just added this as a "reviewer" patch on the original ticket. |
Reviewer: Jason Grout |
Merged: Sage 4.1.2.alpha2 |
comment:3
Replying to @jasongrout:
Yes and no. Why "yes"? --- The patch is about reviewing ticket #3133. Why "no"? --- I wanted to merge #3133, or any ticket with a positive review, as soon as possible without any unnecessary delay. It was only after merging #3133 that I created this follow up ticket. In cases where a ticket has positive review and is ready to be merged seamlessly, I think it can be a waste of time to upload another reviewer patch and get someone to review that patch. It's better to get stuff in as soon as possible where merging it results in no doctest or hunk failures. And indeed some people would find it a waste of time and unnecessary work if I had uploaded another reviewer patch that addresses a micro-bug. Better off to isolate the micro-bug to another ticket, while first merging the ticket with positive review. |
Changed merged from Sage 4.1.2.alpha2 to none |
Merged: Sage 4.1.2.alpha3 |
Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4 |
comment:6
There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package. |
This is a follow up to #3133 to fix some ReST formatting issues.
CC: @jasongrout @kcrisman
Component: documentation
Author: Minh Van Nguyen
Reviewer: Jason Grout
Merged: Sage 4.1.2.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/6963
The text was updated successfully, but these errors were encountered: